Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spack.yaml: depend on generic tracers Spack components #82

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

spack.yaml: depend on generic tracers Spack components #82

wants to merge 7 commits into from

Conversation

harshula
Copy link
Contributor

@harshula harshula commented Oct 7, 2024

Opening this PR to create a pre-release build of ACCESS-OM2 with Spack-built generic tracers components for testing.

@harshula harshula self-assigned this Oct 7, 2024
@harshula
spack.yaml: depend on generic tracers Spack components
9099123
@harshula
versions.json: use the latest versions
7e7a627 
* "spack": "0.22",
* "spack-packages": "development",
* "spack-config": "2024.10.03"
@harshula harshula force-pushed the componentize-generic-tracers branch from 33ff4bd to 7e7a627 Compare October 7, 2024 05:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

The model version in the spack.yaml has not been updated.
Either update it manually, or comment the following to have it updated and committed automatically:

  • !bump major for feature releases
  • !bump minor for bugfixes

@harshula
Copy link
Contributor Author

harshula commented Oct 7, 2024

!bump major

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

❌ Failed to bump version or commit changes, see https://github.com/ACCESS-NRI/ACCESS-OM2/actions/runs/11212418716 ❌

@CodeGat
Copy link
Contributor

CodeGat commented Oct 7, 2024

Token has expired. Will regenerate one tomorrow...considering making it have a longer lifespan 😅

@aidanheerdegen
Copy link
Member

Token has expired. Will regenerate one tomorrow...considering making it have a longer lifespan 😅

Would be good to have a mechanism to remind us when things like this are expiring. Can we generate tokens through an API and set through an API?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

🚀 Deploying access-om2 2024.10.0 as prerelease pr82-4

Details and usage instructions

This access-om2 model will be deployed as:

  • 2024.10.0 as a Release (when merged).
  • pr82-4 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om2/pr82-4

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om2- environment.

🛠️ Using: spack 0.22, spack-packages development, spack-config 2024.07.05

Details

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

aidanheerdegen
aidanheerdegen reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question at this point.

This is fine for testing, but just flagging we have some fork management discussions/decisons to make for those new components before merging.

spack.yaml Outdated
cice5: '{name}/2023.10.19'
mom5: '{name}/2023.11.09'
mom5: '{name}/development'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made me wonder, would we have namespace clash issues with modules in prerelease if two PRs tried to create modules using the same tag or name?

ping @CodeGat for visibility

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect so, now that you mention it...!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we do development_2024.10.08 or dev_2024.10.08?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev_2024.10.08 is sufficiently descriptive and a little less clunky.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future: could we isolate modules into separate namespaces, use the PR name as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we do that? Just change the name of the module, or something fancy with modules that I don't know?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

🚀 Deploying access-om2 2024.10.0 as prerelease pr82-5

Details and usage instructions

This access-om2 model will be deployed as:

  • 2024.10.0 as a Release (when merged).
  • pr82-5 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om2/pr82-5

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om2- environment.

🛠️ Using: spack 0.22, spack-packages development, spack-config 2024.07.05

Details

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited by CodeGat
Loading

🚀 Deploying access-om2 2024.10.0 as prerelease pr82-6

Details and usage instructions

This access-om2 model will be deployed as:

  • 2024.10.0 as a Release (when merged).
  • pr82-6 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om2/pr82-6

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om2- environment.

🛠️ Using: spack 0.22, spack-packages development, spack-config 2024.10.03

Details

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

@CodeGat
Copy link
Contributor

CodeGat commented Oct 8, 2024 •
edited
Loading

Note: the Prerelease succeeded (and is usable), the workflow failed to collect some metadata as the updates to spack-config move directories around. This PR fixes that for future runs: ACCESS-NRI/build-cd#144

@harshula harshula force-pushed the componentize-generic-tracers branch from fb44950 to 799674f Compare October 9, 2024 12:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited by CodeGat
Loading

🚀 Deploying access-om2 2024.10.0 as prerelease pr82-7

Details and usage instructions

This access-om2 model will be deployed as:

  • 2024.10.0 as a Release (when merged).
  • pr82-7 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om2/pr82-7

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om2-pr82-7 environment.

🛠️ Using: spack 0.22, spack-packages development, spack-config 2024.10.03

Details

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

@harshula
Copy link
Contributor Author

harshula commented Oct 9, 2024

Hi @chrisb13 , @anton-seaice , @dougiesquire , This is ready for testing.

@dougiesquire
Copy link
Contributor

dougiesquire commented Oct 9, 2024 •
edited
Loading

Hi @chrisb13 , @anton-seaice , @dougiesquire , This is ready for testing.

I probably won't do any testing while on leave, but if anyone wants to try run this they can use this config. You'll obviously need to modify the config.yaml to use the prerelease module.

@chrisb13
Copy link

Following @dougiesquire suggestion, we've ran a test using this branch (commit 12761ac56fc9c7fa2c80db17f1b0d8c337724ea2). With small modifications to the config.yaml (thanks @jo-basevi!).

The test ran successfully for five years and produced output from ACCESS-OM2 with WOMBAT legacy in generic tracers.

@pearseb also checked the output. NPP screenshot below.

image001

@aidanheerdegen
Copy link
Member

With small modifications to the config.yaml (thanks @jo-basevi!).

Can we get those modifications into this PR?

The test ran successfully for five years and produced output from ACCESS-OM2 with WOMBAT legacy in generic tracers.

Nice. Was this up for debate?

@chrisb13
Copy link

Can we get those modifications into this PR?

The modifications were small but also made to the config repo' (here) so not sure how they'd be incorporated into this PR..?

@aidanheerdegen
Copy link
Member

Oh sorry, I misspoke. As you quite rightly point out the config repo isn't part of this PR, so ignore me. But you can push changes to that branch, or create a new branch with those changes, to make it easier to test.

chrisb13 added a commit to chrisb13/access-om2-configs that referenced this pull request Oct 17, 2024
@chrisb13
tiny changes made to config.yaml to run test of dougiesquire/1deg_jra…
e41c923 
…55_ryf_wombatlite (12761ac) for this ACCESS-NRI/ACCESS-OM2#82.
@chrisb13
Copy link

But you can push changes to that branch, or create a new branch with those changes, to make it easier to test.

Ok as discussed and above, now on a new branch on my own repo', here:
chrisb13/access-om2-configs@e41c923
Do I put in a pull request? (Does it need to get onto the https://github.com/ACCESS-NRI/access-om2-configs ?)

@dougiesquire
Copy link
Contributor

@chrisb13 feel free to just push to the dougiesquire/1deg_jra55_ryf_wombatlite branch (or submit a PR to it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen left review comments

@chrisb13 chrisb13 Awaiting requested review from chrisb13

@dougiesquire dougiesquire Awaiting requested review from dougiesquire

@CodeGat CodeGat Awaiting requested review from CodeGat

@anton-seaice anton-seaice Awaiting requested review from anton-seaice

At least 1 approving review is required to merge this pull request.

Assignees

@harshula harshula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harshula @CodeGat @aidanheerdegen @dougiesquire @chrisb13